Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apparent power attribute (ratedS) on transformers in IIDM #1199

Merged
merged 6 commits into from
Mar 5, 2020
Merged

Add apparent power attribute (ratedS) on transformers in IIDM #1199

merged 6 commits into from
Mar 5, 2020

Commits on Mar 4, 2020

  1. Add RatedS into ThreeWindingsTransformer & TwoWindingsTransformer 

    Signed-off-by: Thomas ADAM <tadam@silicom.fr>
    @tadam50 @miovd
    tadam50 authored and miovd committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    ee331c4 View commit details
    Browse the repository at this point in the history

  2. Add management of RatedS into ThreeWindingsTransformerXML & TwoWindin… 

    …gsTransformerXML

Signed-off-by: Thomas ADAM <tadam@silicom.fr>
    @tadam50 @miovd
    tadam50 authored and miovd committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    c98b6a2 View commit details
    Browse the repository at this point in the history

  3. Taking into account PR remarks : move ratedS from ThreeWindingsTransf… 

    …ormer to Leg

Signed-off-by: Thomas ADAM <tadam@silicom.fr>
    @tadam50 @miovd
    tadam50 authored and miovd committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    3de7474 View commit details
    Browse the repository at this point in the history

  4. SonarCloud Code Analysis : fix code smell 

    Signed-off-by: Thomas ADAM <tadam@silicom.fr>
    @tadam50
    tadam50 committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    2cb02ff View commit details
    Browse the repository at this point in the history

  5. Taking into account PR remarks : add default implementation & using D… 

    …oubleConsumer

Signed-off-by: Thomas ADAM <tadam@silicom.fr>
    @tadam50
    tadam50 committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    befce96 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Taking into account PR remarks : clean code 

    Signed-off-by: Thomas ADAM <tadam@silicom.fr>
    @tadam50
    tadam50 committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    938726d View commit details
    Browse the repository at this point in the history