Add UndirectedGraph.vertexExists(node) method + NodeBreakerView.getOptionalTerminal(node) #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mathbagu Not sure if this is a good idea to do this, but at the very least, what do you think about a |
miovd
changed the title
mathbagu
requested changes
Mar 23, 2020
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerVoltageLevel.java
Outdated
Show resolved
Hide resolved
math/src/main/java/com/powsybl/math/graph/UndirectedGraphImpl.java
Outdated
Show resolved
Hide resolved
miovd
changed the title
…tTerminal(node) behaviour Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com> revert getTerminal and create getOptionalTerminal Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com> revert Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com> correction Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
miovd
changed the title
miovd
force-pushed
the
add_vertexExists_method
branch
from
48f342b
to
9aa536a
Compare
miovd
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
mathbagu
approved these changes
Mar 24, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RALAMBOTIANA MIORA miora.ralambotiana@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
If a node in
NodeBreakerViewdoes not have an attached network component, the methodegetTerminal(node)throws an exception.What is the new behavior (if this is a feature change)?
The method
getOptionalTerminalnow exists and can return an empty Optional if there is no attached network component to a valid node.Does this PR introduce a breaking change or deprecate an API?
No
Other information:
Linked to #1233