Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGMES Operational Limits. Minor improvements #2873

Merged
merged 8 commits into from
Feb 21, 2024

Conversation

marqueslanauja
Copy link
Contributor

@marqueslanauja marqueslanauja commented Jan 25, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior (if this is a feature change)?

Minor improvements after reviewing operational limits:

  • Discard limits defined in the boundary side of dangling lines. (Bad modelling)
  • Separate TerminalMapping::find methods for loading and voltage limits.
  • Allow specific subclasses of loading limits assigned to an equipment.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja marqueslanauja changed the title Cgmes Operational Limits: Minor improvement Cgmes Operational Limits: Minor improvements Jan 25, 2024
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@zamarrenolm zamarrenolm changed the title Cgmes Operational Limits: Minor improvements CGMES Operational Limits. Minor improvements Feb 8, 2024
@marqueslanauja marqueslanauja marked this pull request as ready for review February 16, 2024 09:33
Copy link

sonarcloud bot commented Feb 21, 2024

@annetill annetill merged commit 549c0eb into main Feb 21, 2024
6 checks passed
@annetill annetill deleted the cgmes_operational_limits_minor_improvement branch February 21, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants