Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back static method parseCsv without ReportNode for TimeSeries #2962

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Mar 29, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature/Bug fix

What is the current behavior?
Since v6.3.0, the parseCsv(BufferedReader reader, TimeSeriesCsvConfig timeSeriesCsvConfig) needed a ReportNode as third parameter.

What is the new behavior (if this is a feature change)?
For convenience, a static method parseCsv(BufferedReader reader, TimeSeriesCsvConfig timeSeriesCsvConfig) is again available.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico rolnico requested a review from olperr1 March 29, 2024 15:46
@rolnico rolnico self-assigned this Mar 29, 2024
@rolnico rolnico added the bug label Mar 29, 2024
@rolnico
Copy link
Member Author

rolnico commented Mar 29, 2024

The Sonar issue is (again) the non-parametrized output type (TimeSeries)

Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@olperr1 olperr1 merged commit 9b55fd0 into main Apr 22, 2024
5 of 6 checks passed
@olperr1 olperr1 deleted the nro/add_parsecsv_back branch April 22, 2024 08:13
olperr1 pushed a commit that referenced this pull request May 2, 2024
)

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
(cherry picked from commit 9b55fd0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants