IIDM ThreeWindingsTransformer RatedU0 modification #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
zamarrenolm
requested changes
May 23, 2024
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ThreeWindingsTransformer.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java
Show resolved
Hide resolved
...on/src/test/java/com/powsybl/iidm/modification/TestThreeWindingsTransformerModification.java
Outdated
Show resolved
Hide resolved
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
zamarrenolm
approved these changes
May 23, 2024
annetill
reviewed
May 27, 2024
| private final String transformerId; | ||
| private final Double ratedU0; | ||
|
|
||
| public ThreeWindingsTransformerModification(String transformerId, Double ratedU0) { |
There was a problem hiding this comment.
I am not sure we need a Double here.
There was a problem hiding this comment.
Better double as only one attribute can be modified. Changed.
annetill
approved these changes
May 27, 2024
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
Allows to modify the
ratedU0attribute of a threeWindingsTransformer.As the structural ratio of the three legs must be preserved, the ratedU of the three legs must be adjusted.
To set the
ratedU0attribute I added a new method,setRatedU0, in the threeWindingsTransformer interface.I feel more comfortable with the previous interface where
ratedU0can only be set when the transformer is created.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: