You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please check if the PR fulfills these requirements
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When writing a SvInjection for a fictitious load, the Id of the bus is used for the topological node reference, without regards to the naming strategy.
What is the new behavior (if this is a feature change)?
The topological node reference is the one of the bus and takes into account the naming strategy.
Does this PR introduce a breaking change or deprecate an API?
@zamarrenolm, @annetill, I am not 100% sure my fix is correct but I am 100% that there is a problem here.
I exported a file with the cgmes naming strategy and for the SvInjection associated to a fictitious load, the topological node reference was not a UUID.
@zamarrenolm, @annetill, I am not 100% sure my fix is correct but I am 100% that there is a problem here. I exported a file with the cgmes naming strategy and for the SvInjection associated to a fictitious load, the topological node reference was not a UUID.
You are totally right, there was a missing call to the naming strategy when exporting the topological node of the SvInjection.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When writing a SvInjection for a fictitious load, the Id of the bus is used for the topological node reference, without regards to the naming strategy.
What is the new behavior (if this is a feature change)?
The topological node reference is the one of the bus and takes into account the naming strategy.
Does this PR introduce a breaking change or deprecate an API?