Load default loadflow parameters from json file in classpath #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
geofjamg
reviewed
May 31, 2024
| private final String jsonParametersFile; | ||
|
|
||
| AbstractLoadFlowDefaultParametersLoader(String name, String jsonParametersFile) { | ||
| this.name = name; |
| } | ||
|
|
||
| public LoadFlowParameters(List<LoadFlowDefaultParametersLoader> defaultParametersLoaders) { | ||
| int numberOfLoadersFound = defaultParametersLoaders.size(); |
| } else if (numberOfLoadersFound == 1) { | ||
| LoadFlowDefaultParametersLoader loader = defaultParametersLoaders.get(0); | ||
| JsonLoadFlowParameters.update(this, loader.loadDefaultParametersFromFile()); | ||
| LOGGER.info("Default loadflow configuration has been updated using the reference file from parameters loader '{}'", loader.getSourceName()); |
| this(ServiceLoader.load(LoadFlowDefaultParametersLoader.class) | ||
| .stream() | ||
| .map(ServiceLoader.Provider::get) | ||
| .collect(Collectors.toList())); |
| if (numberOfLoadersFound > 1) { | ||
| List<String> names = defaultParametersLoaders.stream() | ||
| .map(LoadFlowDefaultParametersLoader::getSourceName) | ||
| .collect(Collectors.toList()); |
|
|
||
| AbstractLoadFlowDefaultParametersLoader(String name, String jsonParametersFile) { | ||
| this.name = name; | ||
| this.jsonParametersFile = jsonParametersFile; |
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
geofjamg
approved these changes
May 31, 2024
flo-dup
reviewed
May 31, 2024
...low/loadflow-api/src/test/java/com/powsybl/loadflow/LoadFlowDefaultParametersLoaderMock.java
Show resolved
Hide resolved
flo-dup
approved these changes
May 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
A new way to define default loadflow parameters is added.
The order of loadflow parameters override is now the following :
Only one parameters JSON file can be used, if multiple are found none are used to override parameters