-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CGMES export: report multiple model identifiers #3093
Conversation
Signed-off-by: Luma <zamarrenolm@aia.es>
cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/CgmesExportUtil.java
Outdated
Show resolved
Hide resolved
cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/CgmesExportUtil.java
Outdated
Show resolved
Hide resolved
...ersion/src/test/java/com/powsybl/cgmes/conversion/test/export/CommonGridModelExportTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Luma <zamarrenolm@aia.es>
cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/CgmesExportUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm: In the current state, the PR allows us to retrieve all the ids, but there is nothing to help us know which model they are corresponding to. It would be useful if some other data were also available on each |
I think it would be relatively easy to report the network identifier (to be able to associate the exported uuid with a given network) and the instance file (EQ, SSH, ...). Let me try it ... |
…es identifiers Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm: Thanks for your additions. |
Quality Gate passedIssues Measures |
All the changes asked by flo-dup were made.
* CGMES export report model identifiers * value of constant in message for easy reading * add cgmes subset and network id to the report nodes with exported cgmes identifiers Signed-off-by: Luma <zamarrenolm@aia.es> (cherry picked from commit 62d3644)
* CGMES export report model identifiers * value of constant in message for easy reading * add cgmes subset and network id to the report nodes with exported cgmes identifiers Signed-off-by: Luma <zamarrenolm@aia.es>
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The identifier of the exported model was written in the
Report
under the keyCgmesId
.After the recent refactoring of
Report
, only the firstCgmesId
key present in the report could be retrieved, because the exported model identifiers were written as message templates instead of values.What is the new behavior (if this is a feature change)?
Allow for multiple
CgmesId
values to be present in theReport
output.The identifiers of the exported model must be retrieved by looking at the message of each report node, instead to its message template:
with