[IIDM v1.2] Apparent power attribute on TwoWindingsTransformer and ThreeWindingsTransformer.Leg #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalaig
changed the title
sebalaig
force-pushed
the
issue60-apparent-power
branch
from
1291133
to
9331f97
Compare
sebalaig
changed the title
sebalaig
changed the title
mathbagu
force-pushed
the
integration/v1.1.0
branch
2 times, most recently
from
b4656b2
to
721d27c
Compare
sebalaig
force-pushed
the
issue60-apparent-power
branch
from
9331f97
to
26a2120
Compare
|
This PR seems OK. I'll do another review once the add-version-1.2 branch merged, and this PR rebased. |
mathbagu
added
PR: conflict-with-master
PR: review-ongoing
and removed
PR: waiting-for-review
labels
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
…ate tests Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
sebalaig
force-pushed
the
issue60-apparent-power
branch
from
26a2120
to
54c8a9f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mathbagu
added
PR: ready-to-be-merged
and removed
PR: conflict-with-master
PR: review-ongoing
labels
mathbagu
pushed a commit
that referenced
this pull request
Jul 22, 2020
…reeWindingsTransformer.Leg (#115) Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
mathbagu
pushed a commit
that referenced
this pull request
Sep 9, 2020
…reeWindingsTransformer.Leg (#115) Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
#60
Java PR : powsybl/powsybl-core#1199
Signed-off-by: Sébastien LAIGRE slaigre@silicom.fr
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restIssue #60
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
2WT and 3WT do not have any rated S value
What is the new behavior (if this is a feature change)?
2WT and 3WT have rated S value
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)