Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU Turbo modes don't function #54

Closed
TFHFony opened this issue Dec 30, 2019 · 15 comments
Closed

CPU Turbo modes don't function #54

TFHFony opened this issue Dec 30, 2019 · 15 comments

Comments

@TFHFony
Copy link

@TFHFony TFHFony commented Dec 30, 2019

I have added Illusion City to my site, but it keeps nagging me about the fact that that machine I have set is not running in Turbo mode. When I set the CPU to 4x speed through the Quick Options menu the CPU 4x appears and all works fine. But no matter which option I use:

'CPU_SOFT_TURBO_MULTI' => 4,
'CPU_TURBO_MODE' => 4,
'Z80_SOFT_TURBO_MULTI' => 4,
'Z80_CLOCK_MODE' => 4

The CPU x4 doesn't appear and the software seems to keep running on 3,57Mhz.
In the past the 'CPU_TURBO_MODE' => 4, seemed to work fine. I have added the files and the webpage is: https://www.file-hunter.com/MSX/index.php?id=illusioncity
I hope you can find out what I am doing wrong here.

@TFHFony

This comment has been minimized.

Copy link
Author

@TFHFony TFHFony commented Dec 30, 2019

Additional: Setting the machine to MSX2PPA does give 4 x CPU Speed.

@ppeccin

This comment has been minimized.

Copy link
Owner

@ppeccin ppeccin commented Dec 30, 2019

@TFHFony

This comment has been minimized.

Copy link
Author

@TFHFony TFHFony commented Dec 30, 2019

Hi Paulo,

The game doesn't have any R800 code. It's only Turbo-R because of the speed it requires. Setting the CPU Turbo to 4x through the quick options menu makes the message disappear.
I've also tried older games on my site which have the CPU_TURBO_MODE=1 function but these also are running at 3.57Mhz at the moment. Only setting the MSX2PPA will force the CPU to 4x.
I'm quite sure the function isn't working correctly in 5.4.0.

As for the temporary solution: It's not useable for the current setup of my site :)

@TFHFony

This comment has been minimized.

Copy link
Author

@TFHFony TFHFony commented Jan 1, 2020

Hi Paulo,
I guess this has to do with the reported issue:
3be4e20

@ppeccin

This comment has been minimized.

Copy link
Owner

@ppeccin ppeccin commented Jan 1, 2020

@ppeccin

This comment has been minimized.

Copy link
Owner

@ppeccin ppeccin commented Jan 4, 2020

@TFHFony

This comment has been minimized.

Copy link
Author

@TFHFony TFHFony commented Jan 4, 2020

@TFHFony

This comment has been minimized.

Copy link
Author

@TFHFony TFHFony commented Jan 4, 2020

Hi Paolo,
The archive from Github still serves 5.4.0, but... I have converted your webmsx.org page to a wmsx.js file to do some testing, but... It still doesn't seem to work. Righ now I set the following:

WMSX.AUTO_POWER_ON_DELAY = 0
WMSX.DISKA_URL = "games/IllusionCity.zip";
WMSX.PARAMS.CPU_TURBO_MODE = 4;
WMSX.MACHINE = "MSX2PA";

but the CPU speed doesn't change. I will send you a non-public link by e-mail so you can see it live as well.

Regards!

@ppeccin

This comment has been minimized.

Copy link
Owner

@ppeccin ppeccin commented Jan 4, 2020

@TFHFony

This comment has been minimized.

Copy link
Author

@TFHFony TFHFony commented Jan 4, 2020

@TFHFony

This comment has been minimized.

Copy link
Author

@TFHFony TFHFony commented Jan 4, 2020

@TFHFony

This comment has been minimized.

Copy link
Author

@TFHFony TFHFony commented Jan 4, 2020

OK, I've removed the upper case conversion and checked if all the current arguments were uppercase manually. Now I can add the params argument in lower case and indeed.... It works again:

https://www.file-hunter.com/MSX/index.php?id=illusioncity

Were there any other arguments affected by this bug except for the CPU speed? I might have to check some other games/programms on my site as well :)

@ppeccin

This comment has been minimized.

Copy link
Owner

@ppeccin ppeccin commented Jan 4, 2020

@TFHFony

This comment has been minimized.

Copy link
Author

@TFHFony TFHFony commented Jan 4, 2020

@ppeccin

This comment has been minimized.

Copy link
Owner

@ppeccin ppeccin commented Jan 6, 2020

No problem! Thanks for pointing this bug.

@ppeccin ppeccin closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.