Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearUnwalkableTriangles should be public. #51

Closed
mitm001 opened this Issue Mar 10, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@mitm001
Copy link
Contributor

mitm001 commented Mar 10, 2019

Hi Piotr,

Got something for you to check out before you release 1.2.4.

https://groups.google.com/forum/#!searchin/recastnavigation/flag$20triangles$20in$20navmesh%7Csort:date/recastnavigation/vuyOHdG8NkQ/AA8dOHKYBwAJ

The method markWalkableTriangles is public but clearUnwalkableTriangles is not. Can you make this public?

void clearUnwalkableTriangles(Context ctx, float walkableSlopeAngle, float[] verts, int nv, int[] tris, int nt,

This test is not implemented,

https://github.com/recastnavigation/recastnavigation/blob/05b2b8da80037887d3e79af8a59a8f0f8ed02602/Tests/Recast/Tests_Recast.cpp#L484

Do you have any examples that make use of adding multiple navmeshes and setting the area types using clearUnwalkableTriangles?

// If your input data is multiple meshes, you can transform them here,

Any input would be appreciated.

@ppiastucki

This comment has been minimized.

Copy link
Owner

ppiastucki commented Mar 14, 2019

Thanks for reporting that.
I will make clearUnwalkableTriangles public of course, but you can see that recast4j contains some functionality from release-2.0 branch of recast (https://github.com/recastnavigation/recastnavigation/blob/release-2.0/Recast/Source/Recast.cpp#L307) and you can pass your area type modification to markWalkableTriangles in order to set whatever area type you want instead of the default RC_WALKABLE_AREA.
I guess it makes clearUnwalkableTriangles a bit useless, but since it is still in release-2.0 branch I will keep it in recast4j too.
I am not sure when it is planned to merge this feature from 2.0 to master or release 2.0, you can probably ask recast developers.

ppiastucki pushed a commit that referenced this issue Mar 14, 2019

ppiastucki pushed a commit that referenced this issue Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.