New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak image name #1

Merged
merged 2 commits into from Nov 2, 2017

Conversation

Projects
None yet
1 participant
@ppworks
Owner

ppworks commented Nov 2, 2017

https://docs.docker.com/compose/compose-file/#context
Compose will build and tag it with a generated name, and use that image thereafter.

If I use docker-rails_new directory which is default name of git clone {this repository}, docker-compose run results will give the name as dockerrailsnew_rails to docker image.

I think it's redundant naming.

This PR will improve naming for docker image.

e.g.

cd ~/docker
git clone git@github.com:ppworks/docker-rails_new.git dev
docker-compose run --rm rails-new rails new your-awesome-app --skip-bundle
docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
dev_rails-new       latest              e80dafeae115        11 minutes ago      468MB

@ppworks ppworks merged commit 21f3dc0 into master Nov 2, 2017

@ppworks ppworks deleted the tweak-image-name branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment