New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProxyDrawable doesn't respect the original drawable's parent's IsPresent state #1283

Closed
smoogipoo opened this Issue Dec 22, 2017 · 3 comments

Comments

2 participants
@smoogipoo
Contributor

smoogipoo commented Dec 22, 2017

If a drawable's parent becomes IsPresent = false, its proxied version will still be drawn to the screen.

Resolves ppy/osu#1591.

@smoogipoo smoogipoo added the bug label Dec 22, 2017

@smoogipoo smoogipoo added this to the December 2017 milestone Dec 22, 2017

@smoogipoo smoogipoo self-assigned this Dec 22, 2017

@peppy peppy modified the milestones: December 2017, January 2018 Dec 30, 2017

@peppy

This comment has been minimized.

Member

peppy commented Dec 30, 2017

Moving to January (low priority as we have a local workaround in osu!)

@peppy peppy modified the milestones: January 2018, Candidate Issues Jan 29, 2018

@peppy

This comment has been minimized.

Member

peppy commented Jan 29, 2018

Removing milestone for now.

@peppy peppy modified the milestones: Candidate Issues, March 2018 Mar 5, 2018

@peppy

This comment has been minimized.

Member

peppy commented Mar 5, 2018

Adding back to milestone (still causing issues with approach circles in latest master).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment