Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SQLite dependency with newer .net standard compatible one #1043

Merged
merged 5 commits into from Sep 14, 2017

Conversation

Tom94
Copy link
Collaborator

@Tom94 Tom94 commented Sep 14, 2017

No description provided.

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

@smoogipoo
Copy link
Contributor

I'm not merging this one yet until the MigrateTable stuff is fixed. The following is my status on this:

  • osu! for some reason still fails to add new columns to the DB.
  • Forked the sqlite-net-pcl library, noticed they have a Migration test, which seems to do exactly what we're trying to do, except without explicitly calling MigrateTable (adding a column to an entity).
  • Attempted to get debug SQLite running locally - quite unsuccessfully.

@smoogipoo
Copy link
Contributor

Fixed. Just required a library update (apparently we added a super old stable release). @peppy requesting review

@Tom94 Tom94 merged this pull request into ppy:master Sep 14, 2017
@peppy
Copy link
Sponsor Member

peppy commented Sep 14, 2017

Has been rolled back. Please resubmit.

We need to ensure

  • works with 32 and 64 bit
  • works on linux and macos (at least test one of these)
  • works with old and fresh databases

@peppy
Copy link
Sponsor Member

peppy commented Sep 15, 2017

The remaining issue seems to be documented at praeclarum/sqlite-net#631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants