Fix CircularContainer using DrawSize too early #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could be potentially caching an incorect value.
|
While this looks like a good fix I am a bit concerned about how complicated it is to correctly implement such simple functionality within the framework. Gotta think some more about how this could be done better. |
Tom94
approved these changes
Oct 24, 2017
|
I think the major take-away is that we shouldn't be doing anything in the Invalidate override that queries properties. Another alternative approach here is to just use |
|
I prefer the Cached approach myself since Schedule would need to be cancelled. |
|
good point.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could be potentially caching an incorrect value.
Fixes ppy/osu#1416