New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local all WeakList access in LocalisationEngine #1265

Merged
merged 3 commits into from Dec 17, 2017

Conversation

2 participants
@peppy
Member

peppy commented Dec 17, 2017

This is regularly used from a BackgrounDependencyLoader context, which can cause weird threading issues due to lack of locking on WeakList<>

peppy added some commits Dec 17, 2017

Local all WeakList access in LocalisationEngine
This is regularly used from a BackgrounDependencyLoader context, which can cause weird threading issues due to lack of locking on WeakList<>

fixed!

@smoogipoo smoogipoo merged commit 675fb72 into ppy:master Dec 17, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:lock-localisation-engine branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment