New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessarily aborting WebRequests if they are already completed or aborted #1267

Merged
merged 1 commit into from Dec 17, 2017

Conversation

2 participants
@peppy
Member

peppy commented Dec 17, 2017

This was causing countless unnecessary ObjectDisposedExceptions which impacts performance.

Avoid unnecessarily aborting WebRequests if they are already complete…
…d or aborted

This was causing countless unnecessary ObjectDisposedExceptions which impacts performance.
@smoogipoo

This comment has been minimized.

Show comment
Hide comment
@smoogipoo

smoogipoo Dec 17, 2017

Contributor

"Impacted performance" uh what? Sounds like there's a larger issue if this was noticeable...

Contributor

smoogipoo commented Dec 17, 2017

"Impacted performance" uh what? Sounds like there's a larger issue if this was noticeable...

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 17, 2017

Member

Specifically when debugging, since IDEs tend to handle exceptions even when they are caught.

Member

peppy commented Dec 17, 2017

Specifically when debugging, since IDEs tend to handle exceptions even when they are caught.

@smoogipoo smoogipoo merged commit 0c55d36 into ppy:master Dec 17, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:avoid-unnecessary-aborts branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment