New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't access Children when changing TextSize #1273

Merged
merged 1 commit into from Dec 21, 2017

Conversation

2 participants
@peppy
Member

peppy commented Dec 20, 2017

In cases where a derived class overrided Content this would cause failures. As changing TextSize is a relatively rare thing, there's no reason for this "optimisation" anyways.

Don't access Children when changing TextSize
In cases where a derived class overrided `Content` this would cause failures. As changing TextSize is a relatively rare thing, there's no reason for this "optimisation" anyways.

@peppy peppy added the code quality label Dec 20, 2017

@peppy peppy added this to the December 2017 milestone Dec 20, 2017

@peppy peppy referenced this pull request Dec 20, 2017

Merged

Add URL handling to chat #1667

1 of 1 task complete

@smoogipoo smoogipoo merged commit f6cf11b into ppy:master Dec 21, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-textsize-child-access branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment