New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Tasks in audio components to allow for sync/async handling #1275

Merged
merged 2 commits into from Dec 21, 2017

Conversation

2 participants
@peppy
Member

peppy commented Dec 20, 2017

No description provided.

@smoogipoo

This comment has been minimized.

Show comment
Hide comment
@smoogipoo

smoogipoo Dec 21, 2017

Contributor

How about some unit tests for the state? Specifically for the IsPlaying state?

Contributor

smoogipoo commented Dec 21, 2017

How about some unit tests for the state? Specifically for the IsPlaying state?

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 21, 2017

Member

Definitely need unit tests at some point. Need to investigate how appveyor handles bass playback, though (i think it doesn't at the moment) so we need to address null device playback first.

Member

peppy commented Dec 21, 2017

Definitely need unit tests at some point. Need to investigate how appveyor handles bass playback, though (i think it doesn't at the moment) so we need to address null device playback first.

@smoogipoo smoogipoo merged commit 28fbd07 into ppy:master Dec 21, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:track-bass-async branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment