New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic compilation not working when protected internals are overridden #1281

Merged
merged 5 commits into from Dec 24, 2017

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Dec 22, 2017

No description provided.

@smoogipoo smoogipoo added the testing label Dec 22, 2017

@smoogipoo smoogipoo added this to the December 2017 milestone Dec 22, 2017

@smoogipoo

This comment has been minimized.

Show comment
Hide comment
@smoogipoo

smoogipoo Dec 23, 2017

Contributor

Blocking for a bit - wanna add one more level of protection.

Contributor

smoogipoo commented Dec 23, 2017

Blocking for a bit - wanna add one more level of protection.

@smoogipoo smoogipoo added blocked and removed pending review labels Dec 23, 2017

@smoogipoo smoogipoo added pending review and removed blocked labels Dec 24, 2017

@peppy

peppy approved these changes Dec 24, 2017

@peppy peppy merged commit 64e04b9 into ppy:master Dec 24, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:fix-dynamiccompile-internals branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment