New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce & fix gamewindow refactor #1452

merged 5 commits into from Mar 14, 2018


3 participants

FreezyLemon commented Mar 9, 2018

Reintroduces the changes and fixes the windows bug from #1420 .
This should probably still be tested on all other platforms.

Edit: Closes #1102 (again).

smoogipoo and others added some commits Mar 7, 2018

fix gamewindow refactor to work on windows
also removed a redundant MakeCurrent() call

@FreezyLemon FreezyLemon changed the title from Fix gamewindow refactor to Reintroduce & fix gamewindow refactor Mar 9, 2018

Resize += OnResize;
Move += OnMove;

This comment has been minimized.


smoogipoo Mar 12, 2018


Let's move this to the base GameWindow, since we have an abstract Context now.


This comment has been minimized.


smoogipoo commented Mar 14, 2018

Tested on macOS and Windows, looks ok to me. 👍

@smoogipoo smoogipoo merged commit 4397b26 into ppy:master Mar 14, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded

@FreezyLemon FreezyLemon deleted the FreezyLemon:fix-gamewindow-refactor branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment