New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging of failed response processing to network log #1453

Merged
merged 1 commit into from Mar 12, 2018

Conversation

2 participants
@peppy
Member

peppy commented Mar 10, 2018

Previously misleading "request successful" could be followed by a response process failure, resulting in overall failure.

@peppy peppy added the network label Mar 10, 2018

@peppy peppy added this to the March 2018 milestone Mar 10, 2018

@smoogipoo smoogipoo merged commit 59004b4 into ppy:master Mar 12, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:reponse-process-fail-log branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment