Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SetProportional in BindableNumber #1458

Merged
merged 7 commits into from Apr 17, 2018

Conversation

@jorolf
Copy link
Contributor

@jorolf jorolf commented Mar 12, 2018

No description provided.

@peppy
Copy link
Member

@peppy peppy commented Mar 12, 2018

Hmm, we don't have any automated tests in the visual test for SliderBar. This may be a good opportunity to add a few.

@peppy peppy added this to the Candidate Issues milestone Mar 13, 2018
@jorolf
Copy link
Contributor Author

@jorolf jorolf commented Apr 14, 2018

Just a shower thought: Should we add some easy way to simulate mouse/keyboard actions? The SliderBar mostly reacts to user input only so something like that would be great.

I would imagine it being something like transforms:

TestInputManager(optional?).MoveMouse(new Vector2(100, 100), duration: 0).DragMouse(new Vector2(100, 200), duration: 200, easing: Easing.In);
@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Apr 16, 2018

Would be good @jorolf , but that's for a future consideration.

@peppy
Copy link
Member

@peppy peppy commented Apr 16, 2018

We already have this in the osu! project, right?

@peppy
peppy approved these changes Apr 17, 2018
Copy link
Member

@peppy peppy left a comment

👍

@peppy peppy merged commit fbad10f into ppy:master Apr 17, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants