New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cached delegate for VertexBatch.Add() #1477

Merged
merged 2 commits into from Mar 22, 2018

Conversation

3 participants
@smoogipoo
Contributor

smoogipoo commented Mar 22, 2018

Closes ppy/osu#2274 .

Alternative to ppy/osu#2274, in a way that adds the same change for CompositeDrawable and WaveformGraph, and any future DrawNodes we may implement.

Also removes CustomVertexAction because it's never used and it's probably never going to be used.

@smoogipoo smoogipoo added this to the March 2018 milestone Mar 22, 2018

@smoogipoo smoogipoo referenced this pull request Mar 22, 2018

Merged

Use cached VertexBuffer add delegate #2277

1 of 1 task complete
@peppy

peppy approved these changes Mar 22, 2018

@peppy peppy merged commit cc39713 into ppy:master Mar 22, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Tom94

This comment has been minimized.

Collaborator

Tom94 commented Mar 22, 2018

It is mindblowing to me that the compiler wouldn't make this optimization by itself. Do you have any insights into why?

@smoogipoo smoogipoo deleted the smoogipoo:batch-action-caching branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment