Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to .NET Standard 2.0 #1483

Merged
merged 76 commits into from Mar 27, 2018

Conversation

2 participants
@smoogipoo
Copy link
Contributor

smoogipoo commented Mar 24, 2018

No description provided.

smoogipoo and others added some commits Nov 14, 2017

Merge pull request #1158 from smoogipoo/netstandard
Update with latest master changes
Compile executable projects for both net461 and netcore
Also reordered net461 and netcoreapp2.0 targets to make VS prefer net461.
Merge pull request #1170 from smoogipoo/netstandard
Master merges + support compilation to both netstandard2.0 and net461
Merge pull request #1183 from smoogipoo/netstandard
Merged master + removed unused registry class
Merge pull request #1214 from smoogipoo/netstandard
Merge master into netstandard
loverthehater
tasks.json update
merged to netstandard branch

smoogipoo and others added some commits Mar 26, 2018

Fix webrequest content disposal happening too early on .NET Core
See: https://github.com/dotnet/corefx/blob/master/src/System.Net.Http/src/System/Net/Http/CurlHandler/CurlHandler.EasyRequest.cs#L229-L233

The WebRequest cleanup code will attempt to set the request content stream position to its start position. This cleanup was observed to be while reading the _response_, at which point, due to the `using` statement, the stream content would already be disposed.

@peppy peppy force-pushed the smoogipoo:update-netstandard branch from f3c40bd to 625e15d Mar 27, 2018

@peppy peppy force-pushed the smoogipoo:update-netstandard branch from 1a1dff6 to 5bad477 Mar 27, 2018

@peppy peppy changed the title Update netstandard Switch to .NET Standard 2.0 Mar 27, 2018

@peppy peppy added this to the March 2018 milestone Mar 27, 2018

@peppy

peppy approved these changes Mar 27, 2018

@peppy peppy merged commit b59149e into ppy:master Mar 27, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.