Use Linq.Append and Prepend. #1492
Merged
Conversation
osu.Framework/Input/InputManager.cs
Outdated
| @@ -670,7 +670,7 @@ private bool handleKeyDown(InputState state, Key key, bool repeat) | |||
| { | |||
| IEnumerable<Drawable> queue = inputQueue; | |||
| if (!unfocusIfNoLongerValid()) | |||
| queue = new[] { FocusedDrawable }.Concat(queue); | |||
| queue = queue.Append(FocusedDrawable); | |||
smoogipoo
Apr 2, 2018
Contributor
Doesn't this change the ordering?
Doesn't this change the ordering?
huoyaoyuan
Apr 2, 2018
Author
Contributor
My fault. Should be prepend.
My fault. Should be prepend.
osu.Framework/Input/InputManager.cs
Outdated
| @@ -696,7 +696,7 @@ private bool handleKeyUp(InputState state, Key key) | |||
| { | |||
| IEnumerable<Drawable> queue = inputQueue; | |||
| if (!unfocusIfNoLongerValid()) | |||
| queue = new[] { FocusedDrawable }.Concat(queue); | |||
| queue = queue.Append(FocusedDrawable); | |||
smoogipoo
Apr 2, 2018
Contributor
And here?
And here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
IntelliSense does not show them in completion list, but no error reported. Should be their bug.
Quite minor, and may be merged together with other improvements.