Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUse Linq.Append and Prepend. #1492
Conversation
osu.Framework/Input/InputManager.cs
Outdated
| @@ -670,7 +670,7 @@ private bool handleKeyDown(InputState state, Key key, bool repeat) | ||
| { | ||
| IEnumerable<Drawable> queue = inputQueue; | ||
| if (!unfocusIfNoLongerValid()) | ||
| queue = new[] { FocusedDrawable }.Concat(queue); | ||
| queue = queue.Append(FocusedDrawable); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
osu.Framework/Input/InputManager.cs
Outdated
| @@ -696,7 +696,7 @@ private bool handleKeyUp(InputState state, Key key) | ||
| { | ||
| IEnumerable<Drawable> queue = inputQueue; | ||
| if (!unfocusIfNoLongerValid()) | ||
| queue = new[] { FocusedDrawable }.Concat(queue); | ||
| queue = queue.Append(FocusedDrawable); |
This comment has been minimized.
This comment has been minimized.
smoogipoo
added
the
code quality
label
Apr 2, 2018
smoogipoo
added this to the April 2018 milestone
Apr 2, 2018
peppy
dismissed
smoogipoo’s
stale review
Apr 3, 2018
fixed
peppy
merged commit 6852878
into
ppy:master
Apr 3, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
huoyaoyuan
deleted the
huoyaoyuan:linq
branch
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
huoyaoyuan commentedApr 2, 2018
IntelliSense does not show them in completion list, but no error reported. Should be their bug.
Quite minor, and may be merged together with other improvements.