Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Linq.Append and Prepend. #1492

Merged
merged 1 commit into from Apr 3, 2018
Merged

Use Linq.Append and Prepend. #1492

merged 1 commit into from Apr 3, 2018

Conversation

@huoyaoyuan
Copy link
Contributor

@huoyaoyuan huoyaoyuan commented Apr 2, 2018

IntelliSense does not show them in completion list, but no error reported. Should be their bug.
Quite minor, and may be merged together with other improvements.

osu.Framework/Input/InputManager.cs Outdated
@@ -670,7 +670,7 @@ private bool handleKeyDown(InputState state, Key key, bool repeat)
{
IEnumerable<Drawable> queue = inputQueue;
if (!unfocusIfNoLongerValid())
queue = new[] { FocusedDrawable }.Concat(queue);
queue = queue.Append(FocusedDrawable);

This comment has been minimized.

@smoogipoo

smoogipoo Apr 2, 2018
Contributor

Doesn't this change the ordering?

This comment has been minimized.

@huoyaoyuan

huoyaoyuan Apr 2, 2018
Author Contributor

My fault. Should be prepend.

osu.Framework/Input/InputManager.cs Outdated
@@ -696,7 +696,7 @@ private bool handleKeyUp(InputState state, Key key)
{
IEnumerable<Drawable> queue = inputQueue;
if (!unfocusIfNoLongerValid())
queue = new[] { FocusedDrawable }.Concat(queue);
queue = queue.Append(FocusedDrawable);

This comment has been minimized.

@smoogipoo

smoogipoo Apr 2, 2018
Contributor

And here?

@huoyaoyuan huoyaoyuan force-pushed the huoyaoyuan:linq branch to 8a4c819 Apr 2, 2018
@smoogipoo smoogipoo added this to the April 2018 milestone Apr 2, 2018
@peppy peppy dismissed smoogipoo’s stale review Apr 3, 2018

fixed

@peppy
peppy approved these changes Apr 3, 2018
@peppy peppy merged commit 6852878 into ppy:master Apr 3, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@huoyaoyuan huoyaoyuan deleted the huoyaoyuan:linq branch Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.