Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some file paths causing framework to crash on startup #1495

Merged
merged 1 commit into from Apr 5, 2018

Conversation

2 participants
@peppy
Copy link
Member

peppy commented Apr 3, 2018

Resolves ppy/osu#2319.

This needs to be tested on windows, I have not done so yet.

@smoogipoo

This comment has been minimized.

Copy link
Contributor

smoogipoo commented Apr 3, 2018

How about moving this to an extension method? There are cases in the osu! project that need the same thing (2 other cases).

@smoogipoo

This comment has been minimized.

Copy link
Contributor

smoogipoo commented Apr 3, 2018

Or a FileSafety method

@peppy

This comment has been minimized.

Copy link
Member Author

peppy commented Apr 3, 2018

I'd hope we can DI the GameHost in for those two calls, if possible. Alternatively, if not possible (and the calls are in nUnit code), this solution may be better: https://stackoverflow.com/a/35957875

@peppy peppy force-pushed the peppy:fix-complex-path-failure branch from 726ef98 to 2f43d2f Apr 3, 2018

@peppy peppy force-pushed the peppy:fix-complex-path-failure branch from 2f43d2f to 14e1f13 Apr 3, 2018

@smoogipoo smoogipoo merged commit 444fda9 into ppy:master Apr 5, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-complex-path-failure branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.