Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDelete unnecessary libraries #1496
Conversation
This comment has been minimized.
This comment has been minimized.
|
You should be able to remove the bass ones too (and subsequently - delete the directories entirely). The managedbass nuget package handles these for us. |
This comment has been minimized.
This comment has been minimized.
|
We may eventually need to add some of these back for angle (if we decide to support that), but we can re-visit that at a later point. Did you attempt removing the bass libs too? |
peppy
added
the
code quality
label
Apr 4, 2018
peppy
added this to the April 2018 milestone
Apr 4, 2018
This comment has been minimized.
This comment has been minimized.
|
Yes. The bass libs are definitely necessary, at least on Windows (we talked about that in Discord, I should've posted it here sorry) |
smoogipoo
merged commit 6f723e0
into
ppy:master
Apr 9, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
FreezyLemon
deleted the
FreezyLemon:clean-up-libraries
branch
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
FreezyLemon commentedApr 3, 2018
Apparently these were ported from stable without being used.