Delete unnecessary libraries #1496
Merged
Conversation
Apparently these were ported from stable without being used.
|
You should be able to remove the bass ones too (and subsequently - delete the directories entirely). The managedbass nuget package handles these for us. |
|
We may eventually need to add some of these back for angle (if we decide to support that), but we can re-visit that at a later point. Did you attempt removing the bass libs too? |
|
Yes. The bass libs are definitely necessary, at least on Windows (we talked about that in Discord, I should've posted it here sorry) |
|
Tested on macos and windows, all looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Apparently these were ported from stable without being used.