New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unnecessary libraries #1496

Merged
merged 3 commits into from Apr 9, 2018

Conversation

3 participants
@FreezyLemon
Member

FreezyLemon commented Apr 3, 2018

Apparently these were ported from stable without being used.

Delete unnecessary libraries
Apparently these were ported from stable without being used.
@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented Apr 3, 2018

You should be able to remove the bass ones too (and subsequently - delete the directories entirely). The managedbass nuget package handles these for us.

@peppy

This comment has been minimized.

Member

peppy commented Apr 4, 2018

We may eventually need to add some of these back for angle (if we decide to support that), but we can re-visit that at a later point. Did you attempt removing the bass libs too?

@peppy peppy added the code quality label Apr 4, 2018

@peppy peppy added this to the April 2018 milestone Apr 4, 2018

@FreezyLemon

This comment has been minimized.

Member

FreezyLemon commented Apr 4, 2018

Yes. The bass libs are definitely necessary, at least on Windows (we talked about that in Discord, I should've posted it here sorry)

@smoogipoo

Tested on macos and windows, all looks good.

@smoogipoo smoogipoo merged commit 6f723e0 into ppy:master Apr 9, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@FreezyLemon FreezyLemon deleted the FreezyLemon:clean-up-libraries branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment