Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test StepContainer light colours not always applying correctly #1502

Merged
merged 4 commits into from Apr 9, 2018
Merged

Fix test StepContainer light colours not always applying correctly #1502

merged 4 commits into from Apr 9, 2018

Conversation

peppy
Copy link
Member

@peppy peppy commented Apr 8, 2018

No description provided.

@peppy peppy added this to the April 2018 milestone Apr 8, 2018
smoogipoo
smoogipoo requested changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented below.

@smoogipoo
Copy link
Contributor

This seems to break "Run all steps" on UntilStepButton (all testcases that have this).

@peppy peppy merged commit 44634de into ppy:master Apr 9, 2018
@peppy peppy deleted the fix-test-step-lights branch April 18, 2018 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
type:testing
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peppy @smoogipoo