Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testcase SetUp methods not being properly run #1525

Merged
merged 3 commits into from Apr 18, 2018

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Apr 18, 2018

  1. Steps would be cleared. Barring string-checking for "AdhocTestMethod", this is the only way I've found to determine if we're running under nunit.
  2. All SetUp methods must be run to ensure compatibility with nunit.
@smoogipoo smoogipoo added this to the April 2018 milestone Apr 18, 2018
@peppy
peppy approved these changes Apr 18, 2018
@peppy peppy merged commit f8a75fb into ppy:master Apr 18, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:fix-setup-methods branch Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants