Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upLog exceptions when asset loading fails #1526
Conversation
smoogipoo
added this to the April 2018 milestone
Apr 18, 2018
| { | ||
| Logger.Log($"Couldn't load font asset from {assetName}."); | ||
| Logger.Log($"Couldn't load font asset from {assetName}: {ex.Message}"); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
smoogipoo
Apr 18, 2018
Contributor
I didn't want to log the entire error because all fonts fail to load in rulesets, which would paste a lot of junk into appveyor's output.
This comment has been minimized.
This comment has been minimized.
peppy
merged commit 46ea6cd
into
ppy:master
Apr 18, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
smoogipoo commentedApr 18, 2018
No description provided.