Log exceptions when asset loading fails #1526
Merged
Conversation
| { | ||
| Logger.Log($"Couldn't load font asset from {assetName}."); | ||
| Logger.Log($"Couldn't load font asset from {assetName}: {ex.Message}"); |
peppy
Apr 18, 2018
Member
Logger.Error is preferred
Logger.Error is preferred
smoogipoo
Apr 18, 2018
Author
Contributor
I didn't want to log the entire error because all fonts fail to load in rulesets, which would paste a lot of junk into appveyor's output.
I didn't want to log the entire error because all fonts fail to load in rulesets, which would paste a lot of junk into appveyor's output.
peppy
Apr 18, 2018
Member
Ugh... no way we can make the rulesets correctly load stuff instead?
Ugh... no way we can make the rulesets correctly load stuff instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.