Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log exceptions when asset loading fails #1526

Merged
merged 3 commits into from Apr 18, 2018
Merged

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Apr 18, 2018

No description provided.

@smoogipoo smoogipoo added this to the April 2018 milestone Apr 18, 2018
{
Logger.Log($"Couldn't load font asset from {assetName}.");
Logger.Log($"Couldn't load font asset from {assetName}: {ex.Message}");

This comment has been minimized.

@peppy

peppy Apr 18, 2018
Member

Logger.Error is preferred

This comment has been minimized.

@smoogipoo

smoogipoo Apr 18, 2018
Author Contributor

I didn't want to log the entire error because all fonts fail to load in rulesets, which would paste a lot of junk into appveyor's output.

This comment has been minimized.

@peppy

peppy Apr 18, 2018
Member

Ugh... no way we can make the rulesets correctly load stuff instead?

@peppy
peppy approved these changes Apr 18, 2018
@peppy peppy merged commit 46ea6cd into ppy:master Apr 18, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:asset-fail-logging branch Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants