Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PrimitiveType.Quads with PrimitiveType.TriangleStrip in CircularProgressDrawNode #1532

Merged
merged 5 commits into from Apr 25, 2018

Conversation

2 participants
@jorolf
Copy link
Contributor

jorolf commented Apr 20, 2018

https://www.khronos.org/opengl/wiki/Primitive#Quads states that Quads are legacy api and shouldn't be used

Also reduces memory consumption from 4*N to 2*N+2 where N is the vertex size

jorolf added some commits Apr 20, 2018

@peppy

peppy approved these changes Apr 25, 2018

@peppy peppy added this to the April 2018 milestone Apr 25, 2018

@peppy peppy merged commit 0773d89 into ppy:master Apr 25, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy

This comment has been minimized.

Copy link
Member

peppy commented Apr 25, 2018

good stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.