Ensure host is in a running state before running tests further #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to fix remaining issues.
peppy
force-pushed
the
fix-runaway-threads-2
branch
from
4dec25c
to
4d9350c
Compare
Better safe than
peppy
force-pushed
the
fix-runaway-threads-2
branch
from
eaffbe9
to
0f59882
Compare
Avoids them being thrown in OneTimeTearDown.
smoogipoo
reviewed
Apr 23, 2018
| @@ -91,12 +95,15 @@ void complete() | |||
| }, e => | |||
| { | |||
| complete(); | |||
| throw new Exception("The test case threw an exception while running", e); | |||
| exception = e; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| }); | ||
| }); | ||
|
|
||
| while (!completed && host?.ExecutionState != ExecutionState.Stopped) | ||
| while (!completed && host.ExecutionState == ExecutionState.Running) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smoogipoo
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix remaining issues.