Add CircularProgress.FillTo method #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorolf
reviewed
Apr 28, 2018
|
|
||
| namespace osu.Framework.Graphics.UserInterface | ||
| { | ||
| public class CircularProgress : Drawable, IHasCurrentValue<double> | ||
| { | ||
| public Bindable<double> Current { get; } = new Bindable<double>(); | ||
| private double currentValue |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jorolf
reviewed
Apr 28, 2018
| @@ -59,6 +64,8 @@ protected override void ApplyDrawNode(DrawNode node) | |||
| base.ApplyDrawNode(node); | |||
| } | |||
|
|
|||
| public TransformSequence<CircularProgress> FillTo(double value, int duration) => this.TransformTo(nameof(currentValue), value, duration); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Awaiting #1539 to be merged. |
smoogipoo
requested changes
May 10, 2018
| @@ -59,6 +60,8 @@ protected override void ApplyDrawNode(DrawNode node) | |||
| base.ApplyDrawNode(node); | |||
| } | |||
|
|
|||
| public TransformSequence<CircularProgress> FillTo(double value, int duration) => this.TransformBindableTo(Current, value, duration); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smoogipoo
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ppy/osu#2430 (comment)