Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Clean up BufferedContainer and fix alignment issues #1546
At this point I've spent about 1.5 days trying to nail down the exact frame-by-frame issue, to no avail, so I'm going to PR this as it is a sane change.
The issue that sparked this is ppy/osu#2268 and similar issues happening in BreakOverlay:
It seems that the issue is a mix of invalidation + frame timings + values of
Went through and sanity checked most of
730ef7d - Fix child drawnodes generation
This is the change that fixed the aforementioned issues. It:
In regards to (3) - it's a sane change regardless of it fixing the issue, as the only time
I replicated this in a testcase, though unreliably, through the following code. It'll eventually replicate if you keep reloading the testcase.