Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom AppearDelay per tooltip #1553

Merged
merged 3 commits into from
May 15, 2018
Merged

Conversation

default0
Copy link
Contributor

Does what it says.

Also restructures the checking code around AppearDelay et al to fix some subtle issues (AppearDelay not being honored immediately after creation of a TTC and issues around AppearDelay when combined with moving child-drawables that implement IHasTooltip).

Incidentally, this also easily enables custom AppearDelays per IHasTooltip-Implementation, so it does that too.

This is a breaking change because it adds a member to the IHasTooltip-Interface.

Also makes order of operations and intent on the if-statement less clear
as a small bonus
@@ -177,6 +179,8 @@ private class TooltipTooltipContainer : TooltipContainer, IHasTooltip
{
public string TooltipText { get; set; }

double? IHasTooltip.AppearDelay => null;

This comment was marked as off-topic.

This comment was marked as off-topic.

Copy link
Collaborator

@Tom94 Tom94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you! :)

@Tom94 Tom94 merged commit 47855ca into ppy:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants