Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom AppearDelay per tooltip #1553

Merged
merged 3 commits into from May 15, 2018
Merged

Conversation

@default0
Copy link
Contributor

@default0 default0 commented May 14, 2018

Does what it says.

Also restructures the checking code around AppearDelay et al to fix some subtle issues (AppearDelay not being honored immediately after creation of a TTC and issues around AppearDelay when combined with moving child-drawables that implement IHasTooltip).

Incidentally, this also easily enables custom AppearDelays per IHasTooltip-Implementation, so it does that too.

This is a breaking change because it adds a member to the IHasTooltip-Interface.

default0 added 3 commits May 14, 2018
Also makes order of operations and intent on the if-statement less clear
as a small bonus
@@ -177,6 +179,8 @@ private class TooltipTooltipContainer : TooltipContainer, IHasTooltip
{
public string TooltipText { get; set; }

double? IHasTooltip.AppearDelay => null;

This comment has been minimized.

@Tom94

Tom94 May 15, 2018
Collaborator

Is the access specifier not allowed here?

This comment has been minimized.

@Tom94

Tom94 May 15, 2018
Collaborator

Just checked: yup, it indeed is not allowed. Another day, another piece of knowledge. :)

@Tom94
Tom94 approved these changes May 15, 2018
Copy link
Collaborator

@Tom94 Tom94 left a comment

Very nice, thank you! :)

@Tom94 Tom94 merged commit 47855ca into ppy:master May 15, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants