Move custom AppearDelay into its own interface #1555
Merged
Conversation
namespace osu.Framework.Graphics.Cursor | ||
{ | ||
/// <summary> | ||
/// A tooltip which provides a custom delay until it appears, override the <see cref="TooltipContainer"/>-wide default. |
Aergwyn
May 18, 2018
Member
is there a typo here? Shouldn't it be overriding
?
is there a typo here? Shouldn't it be overriding
?
public interface IHasAppearDelay : IDrawable | ||
{ | ||
/// <summary> | ||
/// The delay until the tooltip should be displayed. Null means the <see cref="TooltipContainer.AppearDelay"/> from the <see cref="TooltipContainer"/> containing the <see cref="Drawable"/> implementing this interface will be used. |
Aergwyn
May 18, 2018
Member
Maybe this doesn't need to mention the null
-case anymore? The interface documentation itself mentions this already.
Maybe this doesn't need to mention the null
-case anymore? The interface documentation itself mentions this already.
/// <summary> | ||
/// A tooltip which provides a custom delay until it appears, override the <see cref="TooltipContainer"/>-wide default. | ||
/// </summary> | ||
public interface IHasAppearDelay : IDrawable |
smoogipoo
May 18, 2018
Contributor
Should inherit from IHasTooltip
.
Should inherit from IHasTooltip
.
Tom94
May 18, 2018
Collaborator
I disagree, unless the interface is renamed to IHasTooltipWithAppearDelay
I disagree, unless the interface is renamed to IHasTooltipWithAppearDelay
smoogipoo
May 18, 2018
Contributor
Given the xmldoc, and given the namespacing of the interface, I believe it should inherit.
Would also be fine with naming it IHasTooltipWithAppearDelay
.
Given the xmldoc, and given the namespacing of the interface, I believe it should inherit.
Would also be fine with naming it IHasTooltipWithAppearDelay
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Avoids the requirement of adding a
null
AppearDelay
to every usage ofIHasTooltip