Move custom AppearDelay into its own interface #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aergwyn
reviewed
May 18, 2018
| namespace osu.Framework.Graphics.Cursor | ||
| { | ||
| /// <summary> | ||
| /// A tooltip which provides a custom delay until it appears, override the <see cref="TooltipContainer"/>-wide default. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| public interface IHasAppearDelay : IDrawable | ||
| { | ||
| /// <summary> | ||
| /// The delay until the tooltip should be displayed. Null means the <see cref="TooltipContainer.AppearDelay"/> from the <see cref="TooltipContainer"/> containing the <see cref="Drawable"/> implementing this interface will be used. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smoogipoo
requested changes
May 18, 2018
| /// <summary> | ||
| /// A tooltip which provides a custom delay until it appears, override the <see cref="TooltipContainer"/>-wide default. | ||
| /// </summary> | ||
| public interface IHasAppearDelay : IDrawable |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
previously approved these changes
May 18, 2018
smoogipoo
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the requirement of adding a
nullAppearDelayto every usage ofIHasTooltip