Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMove custom AppearDelay into its own interface #1555
Conversation
peppy
added
the
code quality
label
May 18, 2018
| namespace osu.Framework.Graphics.Cursor | ||
| { | ||
| /// <summary> | ||
| /// A tooltip which provides a custom delay until it appears, override the <see cref="TooltipContainer"/>-wide default. |
This comment has been minimized.
This comment has been minimized.
| public interface IHasAppearDelay : IDrawable | ||
| { | ||
| /// <summary> | ||
| /// The delay until the tooltip should be displayed. Null means the <see cref="TooltipContainer.AppearDelay"/> from the <see cref="TooltipContainer"/> containing the <see cref="Drawable"/> implementing this interface will be used. |
This comment has been minimized.
This comment has been minimized.
Aergwyn
May 18, 2018
Member
Maybe this doesn't need to mention the null-case anymore? The interface documentation itself mentions this already.
| /// <summary> | ||
| /// A tooltip which provides a custom delay until it appears, override the <see cref="TooltipContainer"/>-wide default. | ||
| /// </summary> | ||
| public interface IHasAppearDelay : IDrawable |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Tom94
May 18, 2018
Collaborator
I disagree, unless the interface is renamed to IHasTooltipWithAppearDelay
This comment has been minimized.
This comment has been minimized.
smoogipoo
May 18, 2018
Contributor
Given the xmldoc, and given the namespacing of the interface, I believe it should inherit.
Would also be fine with naming it IHasTooltipWithAppearDelay.
peppy
dismissed
Tom94’s
stale review
via
2c8373b
May 18, 2018
smoogipoo
merged commit 73e8099
into
ppy:master
May 18, 2018
peppy
deleted the
peppy:appear-delay-to-custom-interface
branch
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
peppy commentedMay 18, 2018
Avoids the requirement of adding a
nullAppearDelayto every usage ofIHasTooltip