New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IBindable and IBindable<T> share some common interfaces #1563

Merged
merged 5 commits into from May 24, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented May 23, 2018

Previously, IBindable didn't have Description, and IBindable<T> didn't have IsDefault, Disabled or DisabledChanged.

This splits those properties out into interfaces common to both interfaces.

I didn't want to make IBindable<T> : IBindable as it would break the restrictions described in the original implementation.

@smoogipoo smoogipoo added this to the May 2018 milestone May 23, 2018

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented May 23, 2018

Don't merge just yet, going to add some additional interface members.

smoogipoo added some commits May 23, 2018

@smoogipoo smoogipoo referenced this pull request May 23, 2018

Merged

Retrieve bindable beatmap directly using DI #2621

2 of 2 tasks complete
@peppy

peppy approved these changes May 24, 2018

@peppy peppy merged commit 2893a3e into ppy:master May 24, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment