New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly dispose previous TestCase when switching to a new one #1564

Merged
merged 1 commit into from May 24, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented May 23, 2018

No description provided.

@smoogipoo smoogipoo added the testing label May 23, 2018

@smoogipoo smoogipoo added this to the May 2018 milestone May 23, 2018

@smoogipoo smoogipoo referenced this pull request May 23, 2018

Merged

Retrieve bindable beatmap directly using DI #2621

2 of 2 tasks complete
@peppy

This comment has been minimized.

Member

peppy commented May 24, 2018

Is there a reason to not just force disposal on test removal in TestBrowser? Currently this seems to be being done for children but not the TestCase itself:

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented May 24, 2018

Yeah that'd be fine

@peppy peppy changed the title from Add cleanup method to TestCase to Explicitly dispose previous TestCase when switching to a new one May 24, 2018

@peppy

peppy approved these changes May 24, 2018

@peppy peppy merged commit f1d2b79 into ppy:master May 24, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment