Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly dispose previous TestCase when switching to a new one #1564

Merged
merged 1 commit into from May 24, 2018

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented May 23, 2018

No description provided.

@smoogipoo smoogipoo added this to the May 2018 milestone May 23, 2018
@smoogipoo smoogipoo mentioned this pull request May 23, 2018
2 of 2 tasks complete
@peppy
Copy link
Member

@peppy peppy commented May 24, 2018

Is there a reason to not just force disposal on test removal in TestBrowser? Currently this seems to be being done for children but not the TestCase itself:

@smoogipoo
Copy link
Contributor Author

@smoogipoo smoogipoo commented May 24, 2018

Yeah that'd be fine

@smoogipoo smoogipoo force-pushed the smoogipoo:testcase-cleanup branch to e277606 May 24, 2018
@peppy peppy changed the title Add cleanup method to TestCase Explicitly dispose previous TestCase when switching to a new one May 24, 2018
@peppy
peppy approved these changes May 24, 2018
@peppy peppy merged commit f1d2b79 into ppy:master May 24, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:testcase-cleanup branch Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants