New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always yield the new state when creating distinct states #1568

Merged
merged 1 commit into from May 27, 2018

Conversation

2 participants
@peppy
Member

peppy commented May 26, 2018

For cases where a custom InputState is being used, there was a chance it was getting lost during distinct state creation. This ensures at the end of creating distinct states we still return the new (original) state.

Always yield the new state when creating distinct states
For cases where a custom InputState is being used, there was a chance it was getting lost during distinct state creation. This ensures at the end of creating distinct states we still return the new (original) state.

@peppy peppy requested a review from smoogipoo May 26, 2018

@peppy peppy referenced this pull request May 26, 2018

Merged

Ensure autoplay tests actually increase score above zero #2644

1 of 1 task complete

@smoogipoo smoogipoo merged commit 84fdfc7 into ppy:master May 27, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-custom-input-states branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment