Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WindowsClipboard.SetText being broken #1573

Merged
merged 5 commits into from Jun 1, 2018

Conversation

@ekrctb
Copy link
Collaborator

@ekrctb ekrctb commented May 29, 2018

Fixes #1572.

@peppy peppy added regression and removed regression labels May 30, 2018
@UselessToucan
Copy link
Contributor

@UselessToucan UselessToucan commented May 30, 2018

Did you check this on both platforms? I mean netcore and net471 on Windows.

@@ -121,7 +121,7 @@ public override void SetText(string selectedText)

try
{
CopyMemory(target, source, bytes);
RtlCopyMemory(target, source, (UIntPtr)bytes);

This comment has been minimized.

@smoogipoo

smoogipoo May 31, 2018
Contributor

Would rather use System.Buffer.MemoryCopy and avoid the pinvoke.

@ekrctb
Copy link
Collaborator Author

@ekrctb ekrctb commented May 31, 2018

I have tested on both net471 and netcore.

@peppy
Copy link
Member

@peppy peppy commented Jun 1, 2018

Seems to work correctly on both runtimes 👍

@peppy peppy dismissed smoogipoo’s stale review Jun 1, 2018

fixed

@peppy
peppy approved these changes Jun 1, 2018
@peppy peppy merged commit 508301b into ppy:master Jun 1, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ekrctb ekrctb deleted the ekrctb:fix-windows-clipboard-copy branch Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants