Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for long paths on windows #1574

Merged
merged 1 commit into from May 31, 2018
Merged

Conversation

@peppy
Copy link
Member

@peppy peppy commented May 29, 2018

Related to fixing ppy/osu#2236.

@peppy peppy added this to the May 2018 milestone May 29, 2018
osu.Framework/Platform/Windows/WindowsStorage.cs Outdated
{
string outPath = base.GetUsablePathFor(path, createIfNotExisting);
// allows traversal of long directory/filenames beyond the standard limitations (see https://stackoverflow.com/a/5188559)
outPath = Regex.Replace(outPath, @"^([a-zA-Z]):\\", @"\\?\$1:\");

This comment has been minimized.

@smoogipoo

smoogipoo May 29, 2018
Contributor

Not sure I like this being done for every single call to GetUsablePathFor. Any reason this is not done on BasePath instead?

@peppy peppy force-pushed the peppy:fix-long-windows-paths branch to f88367d May 29, 2018
@peppy peppy mentioned this pull request May 29, 2018
1 of 1 task complete
@smoogipoo smoogipoo merged commit aebfa5b into ppy:master May 31, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy peppy deleted the peppy:fix-long-windows-paths branch Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants