Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheel values not being aggregated in raw mouse handler #1579

Merged
merged 3 commits into from Jun 1, 2018

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented May 31, 2018

Resolves ppy/osu#2658, resolves #1377.

@peppy
Copy link
Sponsor Member Author

peppy commented May 31, 2018

Ah, on further testing on windows I remember what the remaining issue is: This doesn't cover the discrepancy seen when you toggle raw input - after toggle the conflicting states may cause an incorrect delta still.

I'll probably look at addressing this in a separate PR, though.

state.Wheel = (lastUnfocusedState?.Wheel ?? 0) + (lastRawState?.Wheel ?? 0);

PendingStates.Enqueue(new InputState { Mouse = state });
FrameStatistics.Increment(StatisticsCounterType.MouseEvents);

This comment was marked as off-topic.

@peppy peppy merged commit 804a4b8 into ppy:master Jun 1, 2018
@peppy peppy deleted the fix-raw-mouse-state branch July 5, 2018 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants