Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix wheel values not being aggregated in raw mouse handler #1579
Conversation
peppy
added
the
resolves issue
label
May 31, 2018
This comment has been minimized.
This comment has been minimized.
|
Ah, on further testing on windows I remember what the remaining issue is: This doesn't cover the discrepancy seen when you toggle raw input - after toggle the conflicting states may cause an incorrect delta still. I'll probably look at addressing this in a separate PR, though. |
| state.Wheel = (lastUnfocusedState?.Wheel ?? 0) + (lastRawState?.Wheel ?? 0); | ||
| PendingStates.Enqueue(new InputState { Mouse = state }); | ||
| FrameStatistics.Increment(StatisticsCounterType.MouseEvents); |
This comment has been minimized.
This comment has been minimized.
peppy
merged commit 804a4b8
into
ppy:master
Jun 1, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
peppy
deleted the
peppy:fix-raw-mouse-state
branch
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
peppy commentedMay 31, 2018
•
edited
Resolves ppy/osu#2658, resolves #1377.