Fix broken TransformSequence.Loop #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes regressed loop with finite iteration counts due to missing reset of Applied and AppliedToEnd of clones Transforms - Fixes infinite loops containing Transforms that initially were instantaneously applied
|
No test for spin? :( |
|
Didn't have time to add automation, at which point the specific scenarios that broke down could also get added. Not sure how soon I can find time to do that, but I wanted to at least get a reasonable fix out ASAP. |
This issue still prevented things like `Spin` to work correctly
|
This is now confirmed to fix ppy/osu#2221 |
peppy
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1578
Fixes #1520.
AppliedandAppliedToEndof clonedTransformsTransformsthat initially were instantaneously applied