New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken TransformSequence.Loop #1580

Merged
merged 7 commits into from Jun 1, 2018

Conversation

2 participants
@Tom94
Collaborator

Tom94 commented May 31, 2018

Supersedes #1578
Fixes #1520.

  • Fixes regressed loop with finite iteration counts due to missing reset of Applied and AppliedToEnd of cloned Transforms
  • Fixes infinite loops containing Transforms that initially were instantaneously applied

Tom94 added some commits May 31, 2018

Fix broken TransformSequence.Loop
- Fixes regressed loop with finite iteration counts due to missing reset of Applied and AppliedToEnd of clones Transforms
- Fixes infinite loops containing Transforms that initially were instantaneously applied
@peppy

This comment has been minimized.

Member

peppy commented May 31, 2018

No test for spin? :(

@Tom94

This comment has been minimized.

Collaborator

Tom94 commented May 31, 2018

Didn't have time to add automation, at which point the specific scenarios that broke down could also get added. Not sure how soon I can find time to do that, but I wanted to at least get a reasonable fix out ASAP.

@Tom94

This comment has been minimized.

Collaborator

Tom94 commented Jun 1, 2018

This is now confirmed to fix ppy/osu#2221

@peppy

peppy approved these changes Jun 1, 2018

looks good (went through with @smoogipoo)

@peppy peppy merged commit 0ca467a into ppy:master Jun 1, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment