Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bass sample channels to overwrite older ones by default. #672

merged 5 commits into from Apr 29, 2017
Changes from 1 commit
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

Avoid expensive string formation due to Trace.Assert usage.

  • Loading branch information...
peppy committed Apr 28, 2017
commit cf56470415688f6f5d3722cdbe68b2258b6f89c6
@@ -204,7 +204,9 @@ public bool Remove(T drawable)
bool result = internalChildren.Remove(drawable);
if (!result) return false;

Trace.Assert(drawable.Parent == this, $@"Removed a drawable ({drawable}) whose parent was not this ({this}), but {drawable.Parent}.");
if (drawable.Parent != this)
throw new InvalidOperationException($@"Attemnpt to remove a drawable ({drawable}) whose parent was not this ({this}), but {drawable.Parent}.");

drawable.Parent = null;

if (AutoSizeAxes != Axes.None)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.