New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouse handling on linux #761

Merged
merged 5 commits into from May 29, 2017

Conversation

3 participants
@VPeruS
Contributor

VPeruS commented May 26, 2017

Solve #739

@peppy

peppy approved these changes May 29, 2017

@peppy peppy merged commit fb68990 into ppy:master May 29, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy May 31, 2017

Member

This is not a correct fix. Handling for this was already present using host.IsActive. This means that host.IsActive is still in an incorrect state.

I'm reverting these changes in #774, so please fix IsActive rather than adding the second check.

Member

peppy commented May 31, 2017

This is not a correct fix. Handling for this was already present using host.IsActive. This means that host.IsActive is still in an incorrect state.

I'm reverting these changes in #774, so please fix IsActive rather than adding the second check.

peppy added a commit to peppy/osu-framework that referenced this pull request May 31, 2017

Clean up state handling
Reverts fix in ppy#761 as it is the incorrect way to fix things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment