New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar visual improvements #767

Merged
merged 5 commits into from May 30, 2017

Conversation

3 participants
@peppy
Member

peppy commented May 30, 2017

Adds margin and uses additive blending.

@smoogipoo smoogipoo merged commit 3544176 into ppy:master May 30, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Tom94

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 May 30, 2017

Collaborator

Is this really a performance overhead? I'd rather not have these kinds of microoptimizations in the code.

Collaborator

Tom94 commented on osu.Framework/Graphics/Containers/ScrollContainer.cs in 5e3a1d2 May 30, 2017

Is this really a performance overhead? I'd rather not have these kinds of microoptimizations in the code.

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy May 30, 2017

Member

it's not an optimisation; it stops transform helpers from running more times than necessary (causing animations to slow down)

Member

peppy replied May 30, 2017

it's not an optimisation; it stops transform helpers from running more times than necessary (causing animations to slow down)

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 May 30, 2017

Collaborator

I see. Could you add a comment saying exactly that? It's really non-obvious since the transforms are happening within updateScrollDragger.

Collaborator

Tom94 replied May 30, 2017

I see. Could you add a comment saying exactly that? It's really non-obvious since the transforms are happening within updateScrollDragger.

@Tom94

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 May 30, 2017

Collaborator

For correctness' sake, shouldn't this be scrollDragger.Margin.Bottom?

Collaborator

Tom94 commented on osu.Framework/Graphics/Containers/ScrollContainer.cs in 4733e8e May 30, 2017

For correctness' sake, shouldn't this be scrollDragger.Margin.Bottom?

@Tom94

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 May 30, 2017

Collaborator

scrollDragger.Margin.Right here.

Collaborator

Tom94 commented on osu.Framework/Graphics/Containers/ScrollContainer.cs in 4733e8e May 30, 2017

scrollDragger.Margin.Right here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment