New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely rewrite focus, again #773

Merged
merged 9 commits into from May 30, 2017

Conversation

2 participants
@peppy
Member

peppy commented May 30, 2017

No description provided.

@Tom94

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 May 30, 2017

Collaborator

is

Collaborator

Tom94 commented on osu.Framework/Input/InputManager.cs in 20feb1c May 30, 2017

is

@Tom94

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 May 30, 2017

Collaborator

Need to change "iff" to "if" because of the "or".

Collaborator

Tom94 commented on osu.Framework/Input/InputManager.cs in 20feb1c May 30, 2017

Need to change "iff" to "if" because of the "or".

@Tom94

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 May 30, 2017

Collaborator

Its not the current state. It's whatever state is passed in. I prefer the previous phrasing.

Collaborator

Tom94 commented on osu.Framework/Input/InputManager.cs in 20feb1c May 30, 2017

Its not the current state. It's whatever state is passed in. I prefer the previous phrasing.

@peppy peppy referenced this pull request May 30, 2017

Closed

Fix more focus regressions #769

@Tom94

Tom94 approved these changes May 30, 2017

@Tom94 Tom94 merged commit 3056ec6 into ppy:master May 30, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:common-parent-focus branch May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment