New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various cases of mouse delta values being incorrect #796

Merged
merged 9 commits into from Jun 6, 2017

Conversation

2 participants
@peppy
Member

peppy commented Jun 6, 2017

There are scenarios where we don't want the LastState to be set on a newly arriving MouseState. This covers those cases, and fixes some bugs along the way.

  • InputManager now only assigns the LastState when both the last and current MouseState are of the same type (ie. coming from the same InputHandler source).
  • Fixed multiple bugs with window focus and delta computations.
@Tom94

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 Jun 6, 2017

Collaborator

I don't understand what this comment refers to

Collaborator

Tom94 commented on osu.Framework/Input/InputManager.cs in eeed2be Jun 6, 2017

I don't understand what this comment refers to

@Tom94

Tom94 approved these changes Jun 6, 2017

@peppy peppy merged commit 7d5eb86 into ppy:master Jun 6, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-wheel-delta branch Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment