Fix SortedList<T>.IndexOf(T) returning a valid value for an item not contained by it, instead of -1. #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altering the comparator result logic will work in this particular case, but shouldn't be done for a generic SortedList. This is a slightly better solution.
peppy
approved these changes
Aug 18, 2017
Tom94
reviewed
Aug 18, 2017
| @@ -276,7 +277,7 @@ protected internal void ClearInternal(bool disposeChildren = true) | |||
| /// Used to assign a monotonically increasing ID to children as they are added. This member is | |||
| /// incremented whenever a child is added. | |||
| /// </summary> | |||
| private ulong currentChildID; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Aug 18, 2017
| var newContainer = new Container<Container> { Children = new[] { containerA, containerB } }; | ||
|
|
||
| // Because drawableA and drawableB have been added to separate containers, | ||
| // they will both have Depth = 0 and ChildID = 1, which leads to edge cases if a |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.